nastra commented on code in PR #12821:
URL: https://github.com/apache/iceberg/pull/12821#discussion_r2059725040
##########
core/src/main/java/org/apache/iceberg/view/ViewMetadata.java:
##########
@@ -249,9 +249,23 @@ public Builder setCurrentVersionId(int newVersionId) {
changes.add(new MetadataUpdate.SetCurrentViewVersion(newVersionId));
}
+ // Use the timestamp from the view version if it was added in current
set of changes;
Review Comment:
changing the unit test with the changes you have here in order to match the
`version-log` that we compare against (we compare against a fixed timestamp
defined in `ValidViewMetadata.json`) makes sense to me as this is a consequence
of using the current time millis instead of the view version's time when
setting the view version from 1 to 2 without actually adding view version 2 in
the same builder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
