Xuanwo commented on issue #1254:
URL: https://github.com/apache/iceberg-rust/issues/1254#issuecomment-2829275404
For `CatalogLoader` trait, how about we have a `CatalogConfig` like:
```rust
pub struct CatalogConfig {
name: String,
uri: String,
warehouse: String,
props: HashMap<String, String>,
...others
}
```
So that our CatalogLoader just need to be like:
```rust
pub trait CatalogLoader {
fn load(cfg: CatalogConfig) -> Result<Arc<dyn Catalog>>;
}
```
After this change, our loader itself is dyn compatible. Users who want to
rest specific APIs can start use `RestCatalogBuilder`.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
