dentiny opened a new pull request, #1252: URL: https://github.com/apache/iceberg-rust/pull/1252
## What changes are included in this PR? In this PR, I expose `TableCommit` builder to public, so I could create the instance outside of the crate. Some context why I need this change: - I'm working on a filesystem catalog, which reads and writes everything to and from local filesystem; - This is necessary because: (1) it's beneficial to testing; (2) it's beneficial and easy to setup for our initial customer try out; - To test the `update_table` function, I need to create a table commit instance. Alternatives considered: - Use `std::mem::transmute` to manually hack the object memory, similar to `reinterpret_cast` in C++; - I could use `Transaction` interface to achieve the same effect, but takes more effort. Would appreciate if team has any concerns about it. ## Are these changes tested? N/A, it's a no-op change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
