amogh-jahagirdar commented on code in PR #12736: URL: https://github.com/apache/iceberg/pull/12736#discussion_r2059363985
########## spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRowLevelOperationsWithLineage.java: ########## @@ -0,0 +1,454 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.spark.extensions; + +import static org.apache.iceberg.TableUtil.schemaWithRowLineage; +import static org.apache.iceberg.spark.Spark3Util.loadIcebergTable; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assumptions.assumeThat; + +import java.io.IOException; +import java.util.List; +import java.util.Map; +import java.util.UUID; +import java.util.function.Function; +import org.apache.iceberg.AppendFiles; +import org.apache.iceberg.FileFormat; +import org.apache.iceberg.Files; +import org.apache.iceberg.MetadataColumns; +import org.apache.iceberg.PartitionSpec; +import org.apache.iceberg.Schema; +import org.apache.iceberg.Snapshot; +import org.apache.iceberg.SnapshotRef; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.Table; +import org.apache.iceberg.TestHelpers; +import org.apache.iceberg.data.GenericAppenderFactory; +import org.apache.iceberg.data.GenericRecord; +import org.apache.iceberg.data.Record; +import org.apache.iceberg.encryption.EncryptionUtil; +import org.apache.iceberg.io.DataWriter; +import org.apache.iceberg.io.OutputFile; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.Lists; +import org.apache.iceberg.spark.functions.BucketFunction; +import org.apache.iceberg.types.Types; +import org.apache.iceberg.util.Pair; +import org.apache.iceberg.util.PartitionMap; +import org.apache.spark.sql.catalyst.analysis.NoSuchTableException; +import org.apache.spark.sql.catalyst.parser.ParseException; +import org.junit.jupiter.api.AfterEach; +import org.junit.jupiter.api.BeforeAll; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.TestTemplate; + +public abstract class TestRowLevelOperationsWithLineage extends SparkRowLevelOperationsTestBase { + static final Function<StructLike, StructLike> UNPARTITIONED_GENERATOR = record -> null; + static final Function<StructLike, StructLike> BUCKET_PARTITION_GENERATOR = + record -> + TestHelpers.Row.of(BucketFunction.BucketInt.invoke(2, record.get(0, Integer.class))); + static final Schema SCHEMA = + new Schema( + ImmutableList.of( + Types.NestedField.required(1, "data", Types.IntegerType.get()), + MetadataColumns.ROW_ID, + MetadataColumns.LAST_UPDATED_SEQUENCE_NUMBER)); + + static final List<Record> INITIAL_RECORDS = + ImmutableList.of( + createRecord(0, 0L, 1L), + createRecord(1, 1L, 1L), + createRecord(2, 2L, 1L), + createRecord(3, 3L, 1L), + createRecord(4, 4L, 1L)); + + @BeforeAll + public static void setupSparkConf() { + spark.conf().set("spark.sql.shuffle.partitions", "4"); + } + + @BeforeEach + public void beforeEach() { + assumeThat(formatVersion).isGreaterThanOrEqualTo(3); + // ToDo: Remove these as row lineage inheritance gets implemented in the other readers + assumeThat(fileFormat).isEqualTo(FileFormat.PARQUET); + assumeThat(vectorized).isFalse(); + } + + @AfterEach + public void removeTables() { + sql("DROP TABLE IF EXISTS %s", tableName); + sql("DROP TABLE IF EXISTS source"); + } + + @TestTemplate + public void testMergeIntoWithBothMatchedAndNonMatched() + throws NoSuchTableException, ParseException, IOException { + assumeThat(formatVersion).isGreaterThanOrEqualTo(3); + + createAndInitTable("data INT", null); + createBranchIfNeeded(); + Table table = loadIcebergTable(spark, tableName); + appendRecords(table, partitionRecords(INITIAL_RECORDS, table.spec(), UNPARTITIONED_GENERATOR)); + createOrReplaceView("source", "data INT", "{ \"data\": 1}\n" + "{ \"data\": 5678}\n"); + sql( + "MERGE INTO %s AS t USING source AS s " + + "ON t.data == s.data " + + "WHEN MATCHED THEN " + + " UPDATE SET t.data = 1234 " + + "WHEN NOT MATCHED THEN " + + " INSERT *", + commitTarget()); + + long updateSequenceNumber = latestSnapshot(table).sequenceNumber(); + List<Object[]> rowsWhereIdShouldBePreserved = + sql( + "SELECT data, _row_id, _last_updated_sequence_number FROM %s WHERE data != 5678 ORDER BY _row_id", + selectTarget()); + assertEquals( + "Rows which are carried over or updated should have expected lineage", + ImmutableList.of( + row(0, 0L, 1L), + row(1234, 1L, updateSequenceNumber), + row(2, 2L, 1L), + row(3, 3L, 1L), + row(4, 4L, 1L)), + rowsWhereIdShouldBePreserved); + + // New row with data 5678 should have any row ID higher than the max in the previous commit + // version (4), and have the latest seq number + long previousHighestRowId = 4; + List<Object[]> newRows = + sql( + "SELECT data, _row_id, _last_updated_sequence_number FROM %s WHERE data = 5678 ORDER BY _row_id", + selectTarget()); + assertAddedRowLineage(newRows, 5678, previousHighestRowId, updateSequenceNumber); Review Comment: There may be a simpler way to express this without the filtering in the query...we can get all the records sorted by row ID. Since we know the new record must be at the end we can sublist every element except the last, and assert that. Then take the new record and assert the same stuff as 135 and below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
