kevinjqliu commented on code in PR #1878:
URL: https://github.com/apache/iceberg-python/pull/1878#discussion_r2059186918
##########
tests/table/test_upsert.py:
##########
@@ -511,6 +511,96 @@ def test_upsert_without_identifier_fields(catalog:
Catalog) -> None:
tbl.upsert(df)
+def test_upsert_struct_field_fails_in_join(catalog: Catalog) -> None:
Review Comment:
nit change the name since it no longer fails :)
i also added another test
[here](https://github.com/apache/iceberg-python/pull/1949/files#diff-0a8709ee278f0979ecdcff40f5ff7e215076867112c820b633e3e6f17c827a2eR557-R688)
for when complex type is used as the join key
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
