vrd83 commented on code in PR #1237: URL: https://github.com/apache/iceberg-rust/pull/1237#discussion_r2057606767
########## crates/iceberg/src/transaction/rewrite_manifest.rs: ########## @@ -0,0 +1,389 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +use std::collections::hash_map::Entry; +use std::collections::{HashMap, HashSet}; +use std::future::Future; +use std::hash::Hash; +use std::pin::Pin; + +use itertools::Itertools; +use uuid::Uuid; + +use super::snapshot::{DefaultManifestProcess, SnapshotProduceAction, SnapshotProduceOperation}; +use super::Transaction; +use crate::spec::{ + DataFile, ManifestContentType, ManifestEntry, ManifestFile, ManifestList, ManifestWriter, + Operation, UNASSIGNED_SEQUENCE_NUMBER, UNASSIGNED_SNAPSHOT_ID, +}; +use crate::{Error, ErrorKind, Result}; + +/// New created manifest count during rewrite manifest action. +pub const CREATED_MANIFESTS_COUNT: &str = "manifests-created"; +/// Kept manifest count during rewrite manifest action. +pub const KEPT_MANIFESTS_COUNT: &str = "manifests-kept"; +/// Count of manifest been rewrite and delete during rewrite manifest action. +pub const REPLACED_MANIFESTS_COUNT: &str = "manifests-replaced"; +/// Count of manifest entry been process during rewrite manifest action. +pub const PROCESSED_ENTRY_COUNT: &str = "entries-processed"; + +pub type ClusterFunc<T> = Box<dyn Fn(&DataFile) -> T>; +pub type PredicateFunc = Box<dyn Fn(&ManifestFile) -> Pin<Box<dyn Future<Output = bool> + Send>>>; + +/// Action used for rewriting manifests for a table. +pub struct RewriteManifsetAction<'a, T> { Review Comment: rename `RewriteManifsetAction` to `RewriteManifestAction` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org