mxm commented on code in PR #12527: URL: https://github.com/apache/iceberg/pull/12527#discussion_r2055807355
########## flink/v2.0/flink/src/main/java/org/apache/flink/table/api/runtime/types/FlinkScalaKryoInstantiator.java: ########## @@ -0,0 +1,26 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.flink.table.api.runtime.types; + +/** + * Override Flink's internal FlinkScalaKryoInstantiator to avoid loading the Scala extensions for + * the KryoSerializer. This is a workaround until Kryo-related issues with the Scala extensions are Review Comment: Yes, there is this ticket: https://issues.apache.org/jira/browse/FLINK-37546 I've added it to the comment. ########## flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java: ########## @@ -138,6 +141,12 @@ class IcebergFilesCommitter extends AbstractStreamOperator<Void> this.spec = spec; } + @Override + protected void setup( + StreamTask<?, ?> containingTask, StreamConfig config, Output<StreamRecord<Void>> output) { + super.setup(containingTask, config, output); + } + Review Comment: True, that was an example for a different operator. Generally, calling setup is required for all operators to initialize the task, its config, and its output. Flink moved away from an explicit call to calling this in the constructor of the base class: https://github.com/apache/flink/blob/b0607a15e62b664d15efbda0b0e991f72e45a467/flink-runtime/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java#L166 We are not calling the super constructor, so we need to manually call the setup method. Looking at the code base, Flink 2.0 seems to favor creating a `StreamOperatorFactory`. I've updated the code to use a factory and call the super constructor instead. The setup method overrides are now removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
