bk-mz commented on code in PR #12856:
URL: https://github.com/apache/iceberg/pull/12856#discussion_r2055799165
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -105,28 +108,54 @@ public class SparkMicroBatchStream implements
MicroBatchStream, SupportsAdmissio
this.maxFilesPerMicroBatch = readConf.maxFilesPerMicroBatch();
this.maxRecordsPerMicroBatch = readConf.maxRecordsPerMicroBatch();
+ LOG.info(
+ "Initializing SparkMicroBatchStream with params: branch={},
caseSensitive={}, "
+ + "splitSize={}, splitLookback={}, splitOpenFileCost={},
fromTimestamp={}, "
+ + "maxFilesPerMicroBatch={}, maxRecordsPerMicroBatch={}",
Review Comment:
>or we need this along the code for quick reference ?
this.
>mm, so I am assuming there was no override of the defaults then wouldn't
whats there suff
i was overrriding max rows per batch, but it's not shown in sparkui.
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkMicroBatchStream.java:
##########
@@ -105,28 +108,54 @@ public class SparkMicroBatchStream implements
MicroBatchStream, SupportsAdmissio
this.maxFilesPerMicroBatch = readConf.maxFilesPerMicroBatch();
this.maxRecordsPerMicroBatch = readConf.maxRecordsPerMicroBatch();
+ LOG.info(
+ "Initializing SparkMicroBatchStream with params: branch={},
caseSensitive={}, "
+ + "splitSize={}, splitLookback={}, splitOpenFileCost={},
fromTimestamp={}, "
+ + "maxFilesPerMicroBatch={}, maxRecordsPerMicroBatch={}",
Review Comment:
>or we need this along the code for quick reference ?
this.
>mm, so I am assuming there was no override of the defaults then wouldn't
whats there suff
i was overrriding max rows per batch, but it's not shown in sparkui.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
