yingcai-cy commented on code in PR #80: URL: https://github.com/apache/iceberg-cpp/pull/80#discussion_r2055226952
########## src/iceberg/catalog/memory_catalog.h: ########## @@ -0,0 +1,204 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <mutex> +#include <optional> +#include <unordered_map> + +#include "iceberg/catalog.h" + +namespace iceberg { + +class NamespaceContainer; + +class ICEBERG_EXPORT MemoryCatalog : public Catalog { + public: + MemoryCatalog(std::shared_ptr<FileIO> file_io, std::string warehouse_location); + + void Initialize( + const std::string& name, + const std::unordered_map<std::string, std::string>& properties) override; + + std::string_view name() const override; + + Result<std::vector<TableIdentifier>> ListTables(const Namespace& ns) const override; + + Result<std::unique_ptr<Table>> CreateTable( + const TableIdentifier& identifier, const Schema& schema, const PartitionSpec& spec, + const std::string& location, + const std::unordered_map<std::string, std::string>& properties) override; + + Result<std::unique_ptr<Table>> UpdateTable( + const TableIdentifier& identifier, + const std::vector<std::unique_ptr<UpdateRequirement>>& requirements, + const std::vector<std::unique_ptr<MetadataUpdate>>& updates) override; + + Result<std::shared_ptr<Transaction>> StageCreateTable( + const TableIdentifier& identifier, const Schema& schema, const PartitionSpec& spec, + const std::string& location, + const std::unordered_map<std::string, std::string>& properties) override; + + bool TableExists(const TableIdentifier& identifier) const override; Review Comment: Can these two interfaces also return a result like above, so that we can return clear errors like backend database errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
