jhump opened a new pull request, #402:
URL: https://github.com/apache/iceberg-go/pull/402

   This is a follow-up to #385, which added a similar test for manifest _lists_ 
(but not for manifest files).
   
   I verified the efficacy of this new test by commenting out the calls to 
`ocf.WithDecoderSchemaCache` in `readManifestEntries` and `NewManifestWriter` 
(which were added in #385). When they are commented out, the process uses 
avro's default global cache and the test then fails (as expected) with the 
following:
   
   ```
   === RUN   TestManifests/TestReadManifestIncompleteSchema
       manifest_test.go:911: 
                Error Trace:    
/Users/jhumphries/src/iceberg-go/manifest_test.go:911
                Error:          An error is expected but got nil.
                Test:           TestManifests/TestReadManifestIncompleteSchema
   --- FAIL: TestManifests/TestReadManifestIncompleteSchema (0.00s)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to