RussellSpitzer commented on code in PR #12840:
URL: https://github.com/apache/iceberg/pull/12840#discussion_r2054826950
##########
api/src/main/java/org/apache/iceberg/actions/RewriteManifests.java:
##########
@@ -44,6 +45,28 @@ public interface RewriteManifests
*/
RewriteManifests rewriteIf(Predicate<ManifestFile> predicate);
+ /**
Review Comment:
I think there are still a few issues in this doc
1. This should only produce a single manifest list.
2. Unclear what this is supposed to produce, are we sorting or clustering
here? Will manifests be separated based on values of B and D? Does the order
matter?
```
Rewriting Manifests in this way
* will yield manifest_lists that point to manifest_files containing data
files for common 'd' and
* 'b' partitions.
```
I think the core message here is
Rewrites the manifests and order (cluster?) their entries based on the
specified transforms. Manifests can be filtered based on their min and max
partition values. Choosing a frequently queried partition field can reduce
planning time by skipping unnecessary manifests.
Or something along those lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
