Fokko commented on code in PR #1768:
URL: https://github.com/apache/iceberg-python/pull/1768#discussion_r2054109352
##########
tests/avro/test_file.py:
##########
@@ -335,22 +317,49 @@ def test_all_primitive_types(is_required: bool) -> None:
)
class AllPrimitivesRecord(Record):
- field_fixed: bytes
- field_decimal: Decimal
- field_bool: bool
- field_int: int
- field_long: int
- field_float: float
- field_double: float
- field_date: date
- field_time: time
- field_timestamp: datetime
- field_timestamptz: datetime
- field_string: str
- field_uuid: UUID
-
- def __init__(self, *data: Any, **named_data: Any) -> None:
- super().__init__(*data, **{"struct":
all_primitives_schema.as_struct(), **named_data})
+ @property
+ def field_fixed(self) -> bytes:
+ return self._data[0]
+
+ @property
+ def field_decimal(self) -> Decimal:
+ return self._data[1]
+
+ @property
+ def field_bool(self) -> bool:
+ return self._data[2]
+
+ @property
+ def field_int(self) -> int:
+ return self._data[3]
+
+ @property
+ def field_long(self) -> int:
+ return self._data[4]
+
+ @property
+ def field_float(self) -> float:
+ return self._data[5]
+
+ @property
+ def field_double(self) -> float:
+ return self._data[6]
+
Review Comment:
No it wasn't, thanks for catching this 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
