Fokko commented on code in PR #1940:
URL: https://github.com/apache/iceberg-python/pull/1940#discussion_r2053947917
##########
pyiceberg/table/snapshots.py:
##########
@@ -272,13 +272,10 @@ class SnapshotSummaryCollector:
partition_metrics: DefaultDict[str, UpdateMetrics]
max_changed_partitions_for_summaries: int
- def __init__(self) -> None:
+ def __init__(self, partition_summary_limit: int = 0) -> None:
self.metrics = UpdateMetrics()
self.partition_metrics = defaultdict(UpdateMetrics)
- self.max_changed_partitions_for_summaries = 0
-
- def set_partition_summary_limit(self, limit: int) -> None:
- self.max_changed_partitions_for_summaries = limit
+ self.max_changed_partitions_for_summaries = partition_summary_limit
Review Comment:
```suggestion
self.max_changed_partitions_for_summaries = partition_summary_limit
def set_partition_summary_limit(self, limit: int) -> None:
self.max_changed_partitions_for_summaries = limit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
