ebyhr commented on code in PR #12860: URL: https://github.com/apache/iceberg/pull/12860#discussion_r2053463666
########## docs/docs/daft.md: ########## @@ -125,21 +125,21 @@ Daft and Iceberg have compatible type systems. Here are how types are converted | Iceberg | Daft | |---------|------| | **Primitive Types** | -| `boolean` | [`daft.DataType.bool()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.bool) | -| `int` | [`daft.DataType.int32()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.int32) | -| `long` | [`daft.DataType.int64()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.int64) | -| `float` | [`daft.DataType.float32()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.float32) | -| `double` | [`daft.DataType.float64()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.float64) | -| `decimal(precision, scale)` | [`daft.DataType.decimal128(precision, scale)`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.decimal128) | -| `date` | [`daft.DataType.date()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.date) | -| `time` | [`daft.DataType.time(timeunit="us")`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.int64) | -| `timestamp` | [`daft.DataType.timestamp(timeunit="us", timezone=None)`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.timestamp) | -| `timestampz` | [`daft.DataType.timestamp(timeunit="us", timezone="UTC")`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.timestamp) | -| `string` | [`daft.DataType.string()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.string) | -| `uuid` | [`daft.DataType.binary()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.binary) | -| `fixed(L)` | [`daft.DataType.binary()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.binary) | -| `binary` | [`daft.DataType.binary()`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.binary) | +| `boolean` | [`daft.DataType.bool()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.bool) | +| `int` | [`daft.DataType.int32()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.int32) | +| `long` | [`daft.DataType.int64()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.int64) | +| `float` | [`daft.DataType.float32()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.float32) | +| `double` | [`daft.DataType.float64()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.float64) | +| `decimal(precision, scale)` | [`daft.DataType.decimal128(precision, scale)`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.decimal128) | +| `date` | [`daft.DataType.date()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.date) | +| `time` | [`daft.DataType.time(timeunit="us")`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.int64) | +| `timestamp` | [`daft.DataType.timestamp(timeunit="us", timezone=None)`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.timestamp) | +| `timestampz` | [`daft.DataType.timestamp(timeunit="us", timezone="UTC")`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.timestamp) | +| `string` | [`daft.DataType.string()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.string) | +| `uuid` | [`daft.DataType.binary()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.binary) | +| `fixed(L)` | [`daft.DataType.binary()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.fixed_size_binary) | +| `binary` | [`daft.DataType.binary()`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.binary) | | **Nested Types** | -| `struct(**fields)` | [`daft.DataType.struct(**fields)`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.struct) | -| `list(child_type)` | [`daft.DataType.list(child_type)`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.list) | -| `map(K, V)` | [`daft.DataType.map(K, V)`](https://www.getdaft.io/projects/docs/en/latest/api_docs/datatype.html#daft.DataType.map) | +| `struct(**fields)` | [`daft.DataType.struct(**fields)`](https://www.getdaft.io/projects/docs/en/latest/api/datatypes/#daft.datatype.DataType.struct) | Review Comment: Why does `fields` contain leading `**`? Is it for Python or Rust syntax? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
