wgtmac commented on code in PR #82:
URL: https://github.com/apache/iceberg-cpp/pull/82#discussion_r2051661537
##########
src/iceberg/table_metadata.cc:
##########
@@ -34,6 +38,33 @@ std::string ToString(const MetadataLogEntry& entry) {
entry.metadata_file);
}
+const std::shared_ptr<Schema>& TableMetadata::Schema() const {
+ static const std::shared_ptr<::iceberg::Schema> empty_schema = nullptr;
Review Comment:
I switched to wrap the return in a Result so we can get an explicit
`NotFound` error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
