rdblue commented on code in PR #12836:
URL: https://github.com/apache/iceberg/pull/12836#discussion_r2051043116
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetValueReaders.java:
##########
@@ -161,6 +162,25 @@ public static ParquetValueReader<Long> position() {
return new PositionReader();
}
+ @SuppressWarnings("unchecked")
+ public static ParquetValueReader<Long> rowIds(Long baseRowId,
ParquetValueReader<?> idReader) {
+ if (baseRowId != null) {
+ return new RowIdReader(baseRowId, (ParquetValueReader<Long>) idReader);
+ } else {
+ return ParquetValueReaders.nulls();
+ }
+ }
+
+ @SuppressWarnings("unchecked")
+ public static ParquetValueReader<Long> lastUpdated(
+ Long baseRowId, Long fileLastUpdated, ParquetValueReader<?> seqReader) {
+ if (fileLastUpdated != null && baseRowId != null) {
+ return new LastUpdatedSeqReader(fileLastUpdated,
(ParquetValueReader<Long>) seqReader);
Review Comment:
`baseRowId` is used to detect non-v3 snapshots. It is required for v3
snapshots so when it is missing, the values should be null. That's required by
the spec update in #12781.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
