slfan1989 commented on code in PR #12779:
URL: https://github.com/apache/iceberg/pull/12779#discussion_r2050104933
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/actions/SnapshotTableSparkAction.java:
##########
@@ -124,10 +124,12 @@ private SnapshotTable.Result doExecute() {
StagedSparkTable stagedTable = stageDestTable();
Table icebergTable = stagedTable.table();
- // TODO: Check the dest table location does not overlap with the source
table location
-
boolean threw = true;
try {
+ Preconditions.checkArgument(
+ !sourceTableLocation().equals(icebergTable.location()),
+ "The destination table location overlaps with the source table
location.");
Review Comment:
Thank you for helping review the code! I have made improvements to this part
of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
