rdblue commented on code in PR #12512:
URL: https://github.com/apache/iceberg/pull/12512#discussion_r2049548679
##########
core/src/main/java/org/apache/iceberg/variants/Variants.java:
##########
@@ -120,6 +120,15 @@ public static boolean isNull(ByteBuffer valueBuffer) {
return VariantUtil.readByte(valueBuffer, 0) == 0;
}
+ public static ValueArray array(VariantValue... elements) {
Review Comment:
Minor: there's no need to accept elements here. The other methods create
empty objects so I would probably do that here as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
