manuzhang commented on code in PR #12782:
URL: https://github.com/apache/iceberg/pull/12782#discussion_r2047095263
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/MigrateTableProcedure.java:
##########
@@ -105,10 +105,12 @@ public InternalRow[] call(InternalRow args) {
migrateTableSparkAction =
migrateTableSparkAction.backupTableName(backupTableName);
}
- int parallelism = input.asInt(PARALLELISM_PARAM, 1);
- Preconditions.checkArgument(parallelism > 0, "Parallelism should be larger
than 0");
- migrateTableSparkAction =
-
migrateTableSparkAction.executeWith(SparkTableUtil.migrationService(parallelism));
+ Integer parallelism = input.asInt(PARALLELISM_PARAM, null);
+ if (parallelism != null) {
Review Comment:
This can be simplified into `Preconditions.checkArgument(parallelism == null
|| parallelism > 0, "Parallelism should be larger than 0");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
