huaxiangsun commented on code in PR #12771:
URL: https://github.com/apache/iceberg/pull/12771#discussion_r2045752422


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -174,6 +174,13 @@ private TableProperties() {}
   public static final String PARQUET_BLOOM_FILTER_COLUMN_ENABLED_PREFIX =
       "write.parquet.bloom-filter-enabled.column.";
 
+  public static final String PARQUET_COLUMN_STATS_ENABLED_PREFIX =
+      "write.parquet.stats-enabled.column.";
+
+  public static final String DEFAULT_PARQUET_COLUMN_STATS_ENABLED =
+      PARQUET_COLUMN_STATS_ENABLED_PREFIX + "default";
+  public static final boolean DEFAULT_PARQUET_COLUMN_STATS_ENABLED_DEFAULT = 
true;

Review Comment:
   Was trying to follow the pattern for metrics
   
     public static final String DEFAULT_WRITE_METRICS_MODE = 
"write.metadata.metrics.default";
   
   If it is better, I can change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to