singhpk234 commented on code in PR #12799: URL: https://github.com/apache/iceberg/pull/12799#discussion_r2045010886
########## aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java: ########## @@ -98,14 +100,12 @@ public class S3FileIO private String credential = null; private SerializableSupplier<S3Client> s3; private SerializableSupplier<S3AsyncClient> s3Async; - private S3FileIOProperties s3FileIOProperties; private SerializableMap<String, String> properties = null; - private transient volatile S3Client client; - private transient volatile S3AsyncClient asyncClient; private MetricsContext metrics = MetricsContext.nullMetrics(); private final AtomicBoolean isResourceClosed = new AtomicBoolean(false); private transient StackTraceElement[] createStack; private List<StorageCredential> storageCredentials = ImmutableList.of(); + private transient volatile Cache<String, PrefixedS3Client> s3ClientCache; Review Comment: Would it be better if we use Execution interceptor [doc](https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/core/interceptor/ExecutionInterceptor.html) which gives us the handle of the request, so that we can inspect the request and see which path it refers to ? rather than making a client per perfix ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
