gty404 commented on code in PR #75:
URL: https://github.com/apache/iceberg-cpp/pull/75#discussion_r2043545911
##########
src/iceberg/statistics_file.h:
##########
@@ -99,6 +93,29 @@ struct ICEBERG_EXPORT PartitionStatisticsFile {
std::string path;
/// The size of the partition statistics file in bytes
int64_t file_size_in_bytes;
+
+ /// \brief Compare two PartitionStatisticsFiles for equality.
+ friend bool operator==(const PartitionStatisticsFile& lhs,
+ const PartitionStatisticsFile& rhs) {
+ return lhs.snapshot_id == rhs.snapshot_id && lhs.path == rhs.path &&
+ lhs.file_size_in_bytes == rhs.file_size_in_bytes;
+ }
+
+ /// \brief Compare two PartitionStatisticsFiles for inequality.
+ friend bool operator!=(const PartitionStatisticsFile& lhs,
+ const PartitionStatisticsFile& rhs) {
+ return !(lhs == rhs);
+ }
};
+/// \brief Returns a string representation of a BlobMetadata
Review Comment:
The method name may need to use BlobMetadataToString to avoid conflicts with
the ToString method in member methods ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
