pvary commented on code in PR #12793:
URL: https://github.com/apache/iceberg/pull/12793#discussion_r2042815535


##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/maintenance/operator/TestTriggerManager.java:
##########
@@ -62,6 +62,8 @@ void before() {
     Table table = createTable();
     this.lock = LOCK_FACTORY.createLock();
     this.recoveringLock = LOCK_FACTORY.createRecoveryLock();
+    lock.unlock();
+    recoveringLock.unlock();

Review Comment:
   Could we do this in the `OperatorTestBase`?
   We define the factory there, we should manage the lifecycle there.
   
   We might need to call `super.before()` here, but that is also a good practice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to