kumarpritam863 commented on code in PR #12460:
URL: https://github.com/apache/iceberg/pull/12460#discussion_r2042423856
##########
kafka-connect/kafka-connect/src/main/java/org/apache/iceberg/connect/IcebergSinkConfig.java:
##########
@@ -251,6 +266,9 @@ public IcebergSinkConfig(Map<String, String> originalProps)
{
PropertyUtil.propertiesWithPrefix(originalProps,
AUTO_CREATE_PROP_PREFIX);
this.writeProps = PropertyUtil.propertiesWithPrefix(originalProps,
WRITE_PROP_PREFIX);
+ this.committerConfig =
Review Comment:
Yeah, we can do that and that actually make the contract more compact and
also makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
