xxchan commented on issue #1000:
URL: https://github.com/apache/iceberg-rust/issues/1000#issuecomment-2798433292
`bitvec` is only used by `iceberg::spec::values::Struct`, and its usage
looks not very necessary.
What about
```rust
pub struct Struct {
/// Vector to store the field values
fields: Vec<Literal>,
/// Null bitmap
null_bitmap: BitVec,
}
// change to
pub struct Struct {
/// Vector to store the field values
fields: Vec<Option<Literal>>,
}
```
to remove `tap`/`bitvec`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
