pvary commented on code in PR #12726: URL: https://github.com/apache/iceberg/pull/12726#discussion_r2040348515
########## docs/docs/flink.md: ########## @@ -215,13 +215,17 @@ CREATE CATALOG hive_catalog WITH ( ); ``` -The following properties can be set if using the Hive catalog: Review Comment: Yeah... I agree with you that this is strange. Maybe a sentence and a link pointing to the `flink-configuration/#catalog-configuration` could be nice. And we might be able to remove description of the common fields as well (type, catalog-type, catalog-impl, etc). OTOH on the flink-configuration page the examples are missing for me, but if we want to put them there, then we again duplicating code. Let me think a bit about this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
