zeroshade commented on code in PR #388:
URL: https://github.com/apache/iceberg-go/pull/388#discussion_r2039961869
##########
.github/workflows/go-integration.yml:
##########
@@ -48,11 +48,11 @@ jobs:
- name: Start docker
run: |
- docker compose -f dev/docker-compose.yml up -d
+ docker compose -f recipe/docker-compose.yml up -d
sleep 10
- name: Provision Tables
run: |
- docker compose -f dev/docker-compose.yml exec -T spark-iceberg
ipython ./provision.py
+ docker compose -f recipe/docker-compose.yml exec -T spark-iceberg
ipython ./provision.py
Review Comment:
wouldn't this cause a conflict with the scanner tests that are starting the
test containers locally?
##########
recipe/local_spark.go:
##########
@@ -0,0 +1,67 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package recipe
+
+import (
+ "bytes"
+ "context"
+ _ "embed"
+ "fmt"
+ "io"
+ "os"
+ "testing"
+
+ "golang.org/x/xerrors"
+
+ "github.com/testcontainers/testcontainers-go/modules/compose"
+)
+
+//go:embed docker-compose.yml
+var composeFile []byte
+
+func Start(t *testing.T) error {
Review Comment:
if we're going to do this, I would prefer that this is in an
`internal/recipe` package or something of that kind as I don't want this to be
externally exported from this module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
