smaheshwar-pltr commented on code in PR #1903:
URL: https://github.com/apache/iceberg-python/pull/1903#discussion_r2038639672


##########
tests/integration/test_writes/test_writes.py:
##########
@@ -1683,3 +1683,33 @@ def test_write_optional_list(session_catalog: Catalog) 
-> None:
     session_catalog.load_table(identifier).append(df_2)
 
     assert len(session_catalog.load_table(identifier).scan().to_arrow()) == 4
+
+
+@pytest.mark.integration
+@pytest.mark.parametrize("format_version", [1, 2])
+def test_evolve_and_write(

Review Comment:
   Following 
https://github.com/apache/iceberg-python/pull/1903#discussion_r2038636907, 
probably missing something but not fully understanding this "stack changes" 
(quoting PR description) stuff that this PR enables? Was this test not passing 
before this PR? Asking because I see tests like 
[this](https://github.com/apache/iceberg-python/blob/15887011cb6bae9a4408eedc2824133efa3e1599/tests/catalog/test_sql.py#L1483-L1489)
 that look similar



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to