cmcarthur opened a new pull request, #1176:
URL: https://github.com/apache/iceberg-rust/pull/1176

   ## Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and 
enhancements and this helps us generate change logs for our releases. You can 
link an issue to this PR using the GitHub syntax. For example `Closes #123` 
indicates that this PR will close issue #123.
   -->
   
   - Closes #1174.
   
   ## What changes are included in this PR?
   
   <!--
   Provide a summary of the modifications in this PR. List the main changes 
such as new features, bug fixes, refactoring, or any other updates.
   -->
   
   - Adds a new `AddFieldsAction` which represents an addition of new fields to 
an existing table
   - Adds a new method to Transaction `add_fields` which generates an 
`AddFieldsAction`
   - When applied, the `AddFieldsAction` will register a new schema with the 
addition of the new fields, and set the current schema version to (schema + 1). 
(I am not highly confident that this is the right way to manage the schema id, 
though I've verified that it works in my testing. Is there a better way to mark 
the next schema version as the current one? Is this necessary?)
   
   ## Are these changes tested?
   
   <!--
   Specify what test covers (unit test, integration test, etc.).
   
   If tests are not included in your PR, please explain why (for example, are 
they covered by existing tests)?
   -->
   
   Added tests:
   
   Unit: in crates/iceberg/src/transaction/add_field.rs
   Integration: in crates/integration_tests/tests/shared_tests/add_field_test.rs


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to