wypoon commented on code in PR #12721:
URL: https://github.com/apache/iceberg/pull/12721#discussion_r2035546932
##########
build.gradle:
##########
@@ -763,6 +763,167 @@ project(':iceberg-hive-metastore') {
}
}
+project(':iceberg-hive3-metastore') {
Review Comment:
So the scope of this PR is only building and testing the hive-metastore
module with Hive 2, 3 and 4. As we have seen, we needed code changes for a
single code base to successfully handle working with Hive 2, 3 and 4 HMS. So
until we drop support for Hive 2 and 3, I think we should do this.
In this PR, the base hive-metastore module continues to be built with Hive
2.3.10 (unchanged) and the engines (Flink and Spark) continue to use this base
Hive 2.3.10-built hive-metastore module for testing (and also ship its classes
in their runtime jars).
Since the code is the same now for handling all supported versions of Hive,
the Flink and Spark runtime jars are fine and don't need to change. The
question of testing those engines against possibly multiple versions of HMS is
a separate question. It doesn't need to be settled here. Let's discuss that in
the dev list.
FYI, in https://github.com/apache/iceberg/pull/12693, I have found that
Flink tests all pass with Hive 4, and Spark tests all pass with Hive 3 (but
they do fail with Hive 4).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
