jbonofre commented on code in PR #12644:
URL: https://github.com/apache/iceberg/pull/12644#discussion_r2037902209
##########
format/spec.md:
##########
@@ -1414,12 +1414,16 @@ Each partition field in `fields` is stored as a JSON
object with the following p
| V1 | V2 | V3 | Field | JSON representation |
Example |
|----------|----------|----------|------------------|---------------------|--------------|
-| required | required | omitted | **`source-id`** | `JSON int` | 1
|
Review Comment:
While starting the update of core, I think `source-ids` should be required.
The workflow would be:
1. For the reader:
1.1. We read `source-ids`
1.2. If `source-ids` is not present or null, we read `source-id` (for
backward compatibility)
2. For the writer:
2.1. We write only and always `source-ids` (`source-id` doesn't exist
anymore on new writer)
NB: `source-ids` is a String field as it contains a list, e.g. `1,3,5` for
instqnce (`source-id` is a int field as it's a single value field).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
