divinerapier commented on code in PR #1153:
URL: https://github.com/apache/iceberg-rust/pull/1153#discussion_r2032475520
##########
crates/iceberg/src/io/storage.rs:
##########
@@ -45,6 +47,17 @@ pub(crate) enum Storage {
client: reqwest::Client,
config: Arc<S3Config>,
},
+ #[cfg(feature = "storage-oss")]
+ Oss {
+ /// oss storage could have `oss://`.
+ /// Storing the scheme string here to return the correct path.
+ scheme_str: String,
Review Comment:
```rust
#[cfg(feature = "storage-oss")]
Oss {
/// uses the same client for one FileIO Storage.
///
/// TODO: allow users to configure this client.
client: reqwest::Client,
config: Arc<OssConfig>,
},
```
Fixed, PTAL @liurenjie1024
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
