danielcweeks commented on code in PR #12580: URL: https://github.com/apache/iceberg/pull/12580#discussion_r2021573693
########## format/spec.md: ########## @@ -458,11 +457,11 @@ The snapshot then populates the total number of `added-rows` based on the sum of When the new snapshot is committed, the table's `next-row-id` must also be updated (even if the new snapshot is not in the main branch). Because 225 rows were added (`added1`: 100 + `added2`: 0 + `added3`: 125), the new value is 1,000 + 225 = 1,225: -##### Enabling Row Lineage for Non-empty Tables +##### Row Lineage for Non-empty, Upgraded Tables Any snapshot without the field `first-row-id` does not have any lineage information and values for `_row_id` and `_last_updated_sequence_number` cannot be assigned accurately. -All files that were added before `row-lineage` was enabled should propagate null for all of the `row-lineage` related +All files that were added before upgrading to v3 should propagate null for all of the `row-lineage` related Review Comment: I've updated these references, but there may also be some follow up changes necessary for initial assignment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org