kevinjqliu commented on code in PR #1150:
URL: https://github.com/apache/iceberg-rust/pull/1150#discussion_r2023646275
##########
crates/iceberg/src/transform/bucket.rs:
##########
@@ -167,6 +167,16 @@ impl TransformFunction for Bucket {
.downcast_ref::<arrow_array::TimestampMicrosecondArray>()
.unwrap()
.unary(|v| self.bucket_timestamp(v)),
+ DataType::Time64(TimeUnit::Nanosecond) => input
+ .as_any()
+ .downcast_ref::<arrow_array::Time64NanosecondArray>()
+ .unwrap()
+ .unary(|v| self.bucket_time(v / 1000)),
Review Comment:
there was an issue with rounding when performing division for the hour
transform (https://github.com/apache/iceberg-rust/pull/1146)
but since we're dividing by `1000`, i dont think the same issue applies here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
