rdblue commented on code in PR #12476:
URL: https://github.com/apache/iceberg/pull/12476#discussion_r2006176600
##########
core/src/main/java/org/apache/iceberg/ManifestReader.java:
##########
@@ -133,12 +132,17 @@ private <T extends ContentFile<T>> PartitionSpec
readPartitionSpec(InputFile inp
private static <T extends ContentFile<T>> Map<String, String>
readMetadata(InputFile inputFile) {
Map<String, String> metadata;
try {
- try (AvroIterable<ManifestEntry<T>> headerReader =
- Avro.read(inputFile)
+ try (CloseableIterable<ManifestEntry<T>> headerReader =
+ InternalData.read(FileFormat.AVRO, inputFile)
.project(ManifestEntry.getSchema(Types.StructType.of()).select("status"))
- .classLoader(GenericManifestEntry.class.getClassLoader())
.build()) {
- metadata = headerReader.getMetadata();
+
+ if (headerReader instanceof AvroIterable) {
Review Comment:
Yeah, I think this is reasonable because it should flag cases where we are
using the metadata to recover the partition spec in tests when running with
Parquet or formats that don't support it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
