nastra commented on code in PR #12665:
URL: https://github.com/apache/iceberg/pull/12665#discussion_r2022576907
##########
core/src/main/java/org/apache/iceberg/BaseTable.java:
##########
@@ -232,7 +232,7 @@ public ExpireSnapshots expireSnapshots() {
@Override
public ManageSnapshots manageSnapshots() {
- return new SnapshotManager(name, ops);
+ return new SnapshotManager(name, ops, reporter);
Review Comment:
can you please add some tests for this? Those tests can be similar to what
we have in `ScanPlanningAndReportingTestBase`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
