dolcino-li commented on code in PR #12706:
URL: https://github.com/apache/iceberg/pull/12706#discussion_r2026583674
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -351,6 +353,7 @@ private OverwriteByFilter(Expression overwriteExpr) {
public void commit(WriterCommitMessage[] messages) {
OverwriteFiles overwriteFiles = table.newOverwrite();
overwriteFiles.overwriteByRowFilter(overwriteExpr);
+ overwriteFiles.caseSensitive(caseSensitive);
Review Comment:
Hi, @nastra. I have tested several sql which cover the code you mentioned.
Those case doesn't have this issue. For `delete` command, spark handle case
sensitive issue during analyze part. For CopyOnWrite / SparkPositionDeltaWrite
part, they don't have this issue either, because during commit, they just need
to handle the data-file / delete-file. For replace-where statement, iceberg
need to handle `overwriteExpr` during commit, which cause case sensitive issue.
I only find replace-where statement will set `overwriteExpr`.
Should I also add the case sensitive for those code ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
