danielcweeks commented on code in PR #12712: URL: https://github.com/apache/iceberg/pull/12712#discussion_r2027306627
########## hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java: ########## @@ -80,6 +80,8 @@ public class HiveCatalog extends BaseMetastoreViewCatalog public static final String HMS_DB_OWNER = "hive.metastore.database.owner"; public static final String HMS_DB_OWNER_TYPE = "hive.metastore.database.owner-type"; + private static final String HMS_CLIENT_CLASS = "hms-client-class"; + private static final String HMS_CLIENT_NAME = "hive.metastore.client.class"; Review Comment: I'm not clear on why we need two separate properties here. Can we just use the `hive.metastore.client.class`? Then we don't have two different configs for the same value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
