kevinjqliu commented on code in PR #353:
URL: https://github.com/apache/iceberg-go/pull/353#discussion_r2019196486
##########
table/snapshot_producers.go:
##########
@@ -349,38 +347,3 @@ func (sp *snapshotProducer) commit() ([]Update,
[]Requirement, error) {
AssertRefSnapshotID("main",
sp.txn.meta.currentSnapshotID),
}, nil
}
-
-func truncateUpperBoundText(s string, trunc int) string {
Review Comment:
moved to `table/internal/utils.go`
##########
table/scanner.go:
##########
@@ -488,26 +488,3 @@ func (scan *Scan) ToArrowTable(ctx context.Context)
(arrow.Table, error) {
return array.NewTableFromRecords(schema, records), nil
}
-
-func partitionRecordValue(field iceberg.PartitionField, val iceberg.Literal,
schema *iceberg.Schema) (iceberg.Optional[iceberg.Literal], error) {
Review Comment:
moved to `table/internal/utils.go`
##########
table/internal/interfaces.go:
##########
@@ -66,3 +72,27 @@ type FileReader interface {
// ReadTable reads the entire file and returns it as an arrow table.
ReadTable(context.Context) (arrow.Table, error)
}
+
+type FileFormat interface {
+ Open(context.Context, iceio.IO, string) (FileReader, error)
+ PathToIDMapping(*iceberg.Schema) (map[string]int, error)
+ DataFileStatsFromMeta(rdr Metadata, statsCols
map[int]StatisticsCollector, colMapping map[string]int) *DataFileStatistics
+}
+
+func GetFileFormat(format iceberg.FileFormat) FileFormat {
+ switch format {
+ case iceberg.ParquetFile:
+ return parquetFormat{}
+ default:
+ return nil
+ }
+}
Review Comment:
cc @pvary 😄
##########
table/snapshots_internal_test.go:
##########
@@ -194,14 +194,3 @@ func TestInvalidOperation(t *testing.T) {
_, err := updateSnapshotSummaries(Summary{Operation: OpReplace}, nil,
false)
assert.ErrorIs(t, err, iceberg.ErrNotImplemented)
}
-
-func TestTruncateUpperBoundString(t *testing.T) {
Review Comment:
moved to `table/internal/utils_test.go`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
