lidavidm commented on PR #30: URL: https://github.com/apache/iceberg-cpp/pull/30#issuecomment-2750178633
> Then the only remaining I/O we need to address is the table metadata file which stores a single json string. This is the only reason to keep the `InputFile` and `OutputFile` interfaces. I'm not sure if it is fine to replace them by adding `FileIO::ReadFileFully` and `FileIO::WriteFile`? At that point, do we even need an "IO" abstraction? Just require that the user provide the full string (is a streaming JSON reader necessary here? I got the impression that Iceberg expects that metadata to fit in memory?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
