Xuanwo commented on code in PR #1106:
URL: https://github.com/apache/iceberg-rust/pull/1106#discussion_r2002760992
##########
rust-toolchain.toml:
##########
@@ -16,5 +16,5 @@
# under the License.
[toolchain]
-channel = "nightly-2024-06-10"
+channel = "nightly-2024-10-17"
Review Comment:
I believe those changes are not related. `datafusion` is only used in
`iceberg-datafusion,`.
##########
Cargo.toml:
##########
@@ -94,12 +94,12 @@ serde_json = "1.0.138"
serde_repr = "0.1.16"
serde_with = "3.4"
tempfile = "3.18"
-thrift = "0.17.0"
-tokio = { version = "1.36", default-features = false }
+thrift = "0.17.0"
+tokio = { version = "1.43.0", default-features = false }
Review Comment:
Hi, it's better to avoid updating unrelated crates' versions unless we need
to use their new APIs.
Our `Cargo.toml` maintains the minimal version we are using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
