Fokko commented on code in PR #57:
URL: https://github.com/apache/iceberg-cpp/pull/57#discussion_r2026382385
##########
src/iceberg/schema_internal.cc:
##########
@@ -183,11 +186,171 @@ expected<void, Error> ToArrowSchema(const Schema&
schema, ArrowSchema* out) {
return {};
}
+namespace {
+
+int32_t GetFieldId(const ArrowSchema& schema) {
+ if (schema.metadata == nullptr) {
+ return kUnknownFieldId;
Review Comment:
I think this is fine for now. Later on, we can fetch the field IDs from name
mapping if they are not in the metadata. Or we can assign fresh IDs in case we
want to create a new table from an Arrow schema 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
