danielcweeks commented on code in PR #12655:
URL: https://github.com/apache/iceberg/pull/12655#discussion_r2025506322
##########
core/src/main/java/org/apache/iceberg/rest/RESTCatalog.java:
##########
@@ -65,7 +68,14 @@ public RESTCatalog(Function<Map<String, String>, RESTClient>
clientBuilder) {
public RESTCatalog(
SessionCatalog.SessionContext context,
Function<Map<String, String>, RESTClient> clientBuilder) {
- this.sessionCatalog = new RESTSessionCatalog(clientBuilder, null);
+ this(context, clientBuilder, AuthManagers::loadAuthManager);
+ }
+
+ public RESTCatalog(
+ SessionCatalog.SessionContext context,
+ Function<Map<String, String>, RESTClient> clientBuilder,
+ BiFunction<String, Map<String, String>, AuthManager> authManagerBuilder)
{
Review Comment:
@gh-yzou I think that makes more sense, but we also need to validate the
init session/catalog session creation, which we could either bypass for a
configured auth manager or we could go through the init session/catalog session
setup and let the implementation handle behavior.
Something I think we need a better understanding of, so if you have a use
case that we can fully walk-through, that might be good to validate that this
really address the shared manager issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
