liurenjie1024 commented on code in PR #1139:
URL: https://github.com/apache/iceberg-rust/pull/1139#discussion_r2024870362
##########
crates/iceberg/src/spec/snapshot_summary.rs:
##########
@@ -507,7 +517,21 @@ fn update_totals(
.insert(total_property.to_string(), new_total.to_string());
}
-// TODO: ancestors of function
+// Returns the ancestors of the current snapshot
+#[allow(dead_code)]
+fn ancestors_of(current_snapshot: Snapshot, table_metadata: TableMetadata) ->
Vec<Arc<Snapshot>> {
Review Comment:
Seems this is not used, why we need this method?
##########
crates/iceberg/src/spec/snapshot.rs:
##########
@@ -76,6 +76,16 @@ pub struct Summary {
pub additional_properties: HashMap<String, String>,
}
+impl Summary {
+ /// Create new snapshot summary
+ pub fn new(operation: Operation) -> Self {
Review Comment:
`Summary` is supposed to be built from `SummaryCollector`, so I think we
should not have this in public api?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
