Fokko commented on PR #369: URL: https://github.com/apache/iceberg-go/pull/369#issuecomment-2770500071
Also, V2 tables need a bit of TLC. I've added the comments using a `#`: ```json { "status": 1, "snapshot_id": { "long": 3987426542168867673 # The snapshot should be inherited }, "sequence_number": { "long": -1 # This should be null, since status is added, it should be inherited like file_sequence_number }, "file_sequence_number": null, "data_file": { "content": 0, "file_path": "/tmp/merge-manifests/data/00000-0-8d0f1dd8-0398-4143-bb08-ff49c710311e.parquet", "file_format": "PARQUET", "record_count": 3, "file_size_in_bytes": 4848, "column_sizes": { ... }, "value_counts": { ... }, "null_value_counts": { ... }, "nan_value_counts": { ... }, "lower_bounds": { ... }, "upper_bounds": { ... }, "key_metadata": null, "split_offsets": { "array": [ 4 ] }, "equality_ids": null, "sort_order_id": null, "partition": {} } } { "status": 0, "snapshot_id": { "long": 3987426542168867673. # Similar to the issue above, this should be the snapshot-id when the file was added }, "sequence_number": { "long": -1 # This should be 2, with status existing, snapshot inheritance is not possible }, "file_sequence_number": { "long": 2 }, "data_file": { "content": 0, "file_path": "/tmp/merge-manifests/data/00000-0-a1142919-65c2-4eeb-8345-0ecdb5210a26.parquet", "file_format": "PARQUET", "record_count": 3, "file_size_in_bytes": 4848, "column_sizes": { ... }, "value_counts": { ... }, "null_value_counts": { ... }, "nan_value_counts": { ... }, "lower_bounds": { ... }, "upper_bounds": { ... }, "key_metadata": null, "split_offsets": { "array": [ 4 ] }, "equality_ids": null, "sort_order_id": null, "partition": {} } } { "status": 0, "snapshot_id": { "long": 3987426542168867673 }, "sequence_number": { "long": 1 }, "file_sequence_number": { "long": 1 }, "data_file": { "content": 0, "file_path": "/tmp/merge-manifests/data/00000-0-4bbe328f-e532-4931-b008-adca58fbb51d.parquet", "file_format": "PARQUET", "record_count": 3, "file_size_in_bytes": 4848, "column_sizes": { ... }, "value_counts": { ... }, "null_value_counts": { ... }, "nan_value_counts": { ... }, "lower_bounds": { ... }, "upper_bounds": { ... }, "key_metadata": null, "split_offsets": { "array": [ 4 ] }, "equality_ids": null, "sort_order_id": null, "partition": {} } } ``` It would be good to have some tests here as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org