nastra commented on code in PR #12612:
URL: https://github.com/apache/iceberg/pull/12612#discussion_r2022218219
##########
aws/src/test/java/org/apache/iceberg/aws/AwsClientPropertiesTest.java:
##########
@@ -213,8 +227,12 @@ public void refreshCredentialsEndpointWithRelativePath() {
.extracting("properties")
.isEqualTo(
ImmutableMap.of(
+ CatalogProperties.URI,
+ "http://localhost:1234/v1";, // Ensure CatalogProperties.URI is
used as the base URI
"credentials.uri",
- "http://localhost:1234/v1/relative/credentials/endpoint";,
+ "http://localhost:1234/v1/relative/credentials/endpoint";, //
Ensure the relative path is resolved correctly
Review Comment:
```suggestion
"http://localhost:1234/v1/relative/credentials/endpoint";,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
