Fokko commented on code in PR #1867:
URL: https://github.com/apache/iceberg-python/pull/1867#discussion_r2021735921
##########
pyiceberg/io/pyarrow.py:
##########
@@ -1777,7 +1777,7 @@ def struct(
field_arrays.append(array)
fields.append(self._construct_field(field, array.type))
elif field.optional:
- arrow_type = schema_to_pyarrow(field.field_type,
include_field_ids=False)
+ arrow_type = schema_to_pyarrow(field.field_type,
include_field_ids=self._include_field_ids)
Review Comment:
Yes, we missed this in a review 🤦 Field-IDs are superior over name-mapping,
for example: dropping a field, and then adding a new field with the same name
is not supported by name-mapping because it re-uses the name. In the case of
field-IDs, a new ID is assigned and it will look like a new column 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
