flyrain commented on code in PR #12418:
URL: https://github.com/apache/iceberg/pull/12418#discussion_r2021374263
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/procedures/CreateChangelogViewProcedure.java:
##########
@@ -210,7 +210,12 @@ private Dataset<Row> removeCarryoverRows(Dataset<Row> df,
boolean netChanges) {
}
Column[] repartitionSpec =
-
Arrays.stream(df.columns()).filter(columnsToKeep).map(df::col).toArray(Column[]::new);
+ Arrays.stream(df.columns())
+ .filter(columnsToKeep)
+ .map(CreateChangelogViewProcedure::delimitedName)
+ .map(df::col)
+ .toArray(Column[]::new);
Review Comment:
sql1:
```
CALL spark_catalog.system.create_changelog_view(
table => 'db.tbl',
options => map('start-snapshot-id', '1', 'end-snapshot-id', '2'),
identifier_columns => array('user id', 'name')
)
```
sql2:
```
CALL spark_catalog.system.create_changelog_view(
table => 'db.tbl',
options => map('start-snapshot-id', '1', 'end-snapshot-id', '2'),
identifier_columns => array('`user id`', 'name')
)
```
Looks like sql1 just fail at sql parsing. Users will need to fix the syntax
error to pass. It's fine then. Thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
