Re: [PR] Spec: Allow the use of `source-id` in V3 [iceberg]

[via GitHub]

Fokko commented on code in PR #12644:
URL: https://github.com/apache/iceberg/pull/12644#discussion_r2021334130


##########
format/spec.md:
##########
@@ -1414,12 +1414,16 @@ Each partition field in `fields` is stored as a JSON 
object with the following p
 
 | V1       | V2       | V3       | Field            | JSON representation | 
Example      |
 
|----------|----------|----------|------------------|---------------------|--------------|
-| required | required | omitted  | **`source-id`**  | `JSON int`          | 1  
          |

Review Comment:
   Ah, I see the confusion. Some examples. In the case of a single arg:
   ```json
   {"field-id": 1000, "source-id": 1, "name": "bucket_user_id", "transform": 
"bucket[16]"} 
   ```
   In the case of a multi-arg:
   ```json
   {"field-id": 1000, "source-ids": [1, 2], "name": "bucket_user_id", 
"transform": "bucket[16]"} 
   ```
   The benefit is that we don't have to carry the `format-version` to the 
serializers. So, they are mutually exclusive, and one of them is required, 
indicated by the `¹`:
   
   
![image](https://github.com/user-attachments/assets/16f9fe8f-dc6d-446b-8a2d-d2e03a82d1e9)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org