norton120 opened a new pull request, #1863:
URL: https://github.com/apache/iceberg-python/pull/1863
# Rationale for this change
Our data lake uses old-school Kimball style quoted column names ("User ID",
"Customer Name" etc). The string parser for `row_filter` was unable to parse
this. Now it is.
example:
```python
# before
>> parser.parse(' "User Name" = 'ted')
ParseException: Expected '"', found ' '
# after
>> parser.parse(' "User Name" = 'ted')
EqualTo("User Name", "ted")
# Are these changes tested?
Yes a new test was added.
```
>[!NOTE]
> The `quoted_column_with_dots` previously errored `with "Expected '"',
found '.'"` _when using **double quotes only**_. It now raises error text
expecting an `'or'` value; I didn't toil over finding where the exception is
clobbered, because the error message between single and double quote exceptions
is inconsistent and I didn't really consider this a polished/first-class error
message. If this change is an issue, I can dig further to try and revert the
wording change; IMO raising the same exception type is more than reasonable to
consider the change non-breaking.
# Are there any user-facing changes?
Yes quoted identifiers are now supported
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
